This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "GNU Library General Public License, Version 2.0", "GNU Lesser
     General Public License, Version 2.1", "GNU Lesser General Public
     License, Version 3", "*No copyright* GNU General Public License,
     Version 3", "*No copyright* GNU Lesser General Public License, Version
     3", "GNU Library General Public License v2 or later". 200 files have
     unknown license. Detailed output of licensecheck in /var/lib/copr-
     rpmbuild/results/plasma-phone-components/licensecheck.txt
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[ ]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define kf5_version 5.89.0,
     %{!?_plasma5_bugfix: %define _plasma5_bugfix %{version}},
     %{!?_plasma5_version: %define _plasma5_version %(echo
     %{_plasma5_bugfix} | awk -F. '{print $1"."$2}')}
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[ ]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 2611200 bytes in /usr/share


Installation errors
-------------------
INFO: mock.py version 2.15 starting (python version = 3.9.7, NVR = mock-2.15-1.fc34)...
Start: init plugins
INFO: tmpfs initialized
INFO: selinux enabled
INFO: chroot_scan: initialized
INFO: compress_logs: initialized
Finish: init plugins
INFO: Signal handler active
Start: run
Start: chroot init
INFO: mounting tmpfs at /var/lib/mock/fedora-rawhide-x86_64/root.
INFO: reusing tmpfs at /var/lib/mock/fedora-rawhide-x86_64/root.
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 2.15
INFO: Mock Version: 2.15
Finish: chroot init
INFO: installing package(s): /var/lib/copr-rpmbuild/results/plasma-phone-components-5.23.4-1.fc36.x86_64.rpm
WARNING: Dnf command failed, retrying, attempt #2, sleeping 10s
WARNING: Dnf command failed, retrying, attempt #3, sleeping 10s
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 36 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk --disableplugin=versionlock install /var/lib/copr-rpmbuild/results/plasma-phone-components-5.23.4-1.fc36.x86_64.rpm --setopt=tsflags=nocontexts --setopt=tsflags=nocontexts --setopt=tsflags=nocontexts



Rpmlint
-------
Checking: plasma-phone-components-5.23.4-1.fc36.x86_64.rpm
          plasma-phone-components-5.23.4-1.fc36.src.rpm
plasma-phone-components.x86_64: W: incoherent-version-in-changelog oda ['5.23.4-1.fc36', '5.23.4-1']
plasma-phone-components.x86_64: W: invalid-license GPL-2.0-or-later
plasma-phone-components.x86_64: W: unstripped-binary-or-object /usr/lib64/qt5/plugins/plasma/applets/plasma_applet_phonepanel.so
plasma-phone-components.x86_64: W: unstripped-binary-or-object /usr/lib64/qt5/plugins/plasma/applets/plasma_containment_phone_homescreen.so
plasma-phone-components.x86_64: W: unstripped-binary-or-object /usr/lib64/qt5/plugins/plasma/applets/plasma_containment_phone_taskpanel.so
plasma-phone-components.x86_64: W: unstripped-binary-or-object /usr/lib64/qt5/qml/org/kde/plasma/mm/libppc-mmqmlplugin.so
plasma-phone-components.x86_64: W: unstripped-binary-or-object /usr/lib64/qt5/qml/org/kde/plasma/private/mobilehomescreencomponents/libmobilehomescreencomponentsplugin.so
plasma-phone-components.x86_64: W: no-documentation
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/look-and-feel/org.kde.plasma.phone/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.plasma.phone.desktop
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/plasmoids/org.kde.phone.activities/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.phone.activities.desktop
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/plasmoids/org.kde.phone.homescreen/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.phone.homescreen.desktop
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/plasmoids/org.kde.phone.krunner/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.phone.krunner.desktop
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/plasmoids/org.kde.phone.panel/contents/ui/indicators/Indicator.qml /usr/share/plasma/look-and-feel/org.kde.plasma.phone/contents/lockscreen/indicators/Indicator.qml
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/plasmoids/org.kde.phone.panel/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.phone.panel.desktop
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/plasmoids/org.kde.phone.taskpanel/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.phone.taskpanel.desktop
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/quicksettings/org.kde.plasma.airplanemode/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.plasma.airplanemode.desktop
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/quicksettings/org.kde.plasma.nightcolor/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.plasma.nightcolor.desktop
plasma-phone-components.x86_64: W: cross-directory-hard-link /usr/share/plasma/shells/org.kde.plasma.phoneshell/metadata.desktop /usr/share/kservices5/plasma-applet-org.kde.plasma.phoneshell.desktop
plasma-phone-components.x86_64: W: no-manual-page-for-binary kwinwrapper
plasma-phone-components.src: W: invalid-license GPL-2.0-or-later
plasma-phone-components.src:62: W: macro-in-comment %lang_package
2 packages and 0 specfiles checked; 0 errors, 21 warnings.




Unversioned so-files
--------------------
plasma-phone-components: /usr/lib64/qt5/plugins/plasma/applets/plasma_applet_phonepanel.so
plasma-phone-components: /usr/lib64/qt5/plugins/plasma/applets/plasma_containment_phone_homescreen.so
plasma-phone-components: /usr/lib64/qt5/plugins/plasma/applets/plasma_containment_phone_taskpanel.so
plasma-phone-components: /usr/lib64/qt5/qml/org/kde/plasma/mm/libppc-mmqmlplugin.so
plasma-phone-components: /usr/lib64/qt5/qml/org/kde/plasma/private/mobilehomescreencomponents/libmobilehomescreencomponentsplugin.so

Source checksums
----------------
https://download.kde.org/stable/plasma/5.23.4/plasma-phone-components-5.23.4.tar.xz :
  CHECKSUM(SHA256) this package     : c96f341921dfc2bfd49fba5549e4f515b96144eac369504ae9955a90a2bf8556
  CHECKSUM(SHA256) upstream package : c96f341921dfc2bfd49fba5549e4f515b96144eac369504ae9955a90a2bf8556


Requires
--------
plasma-phone-components (rpmlib, GLIBC filtered):
    /usr/bin/sh
    kf5-bluez-qt
    kf5-kactivities
    kf5-kdeclarative
    kf5-kirigami2
    kwin
    libKF5ConfigCore.so.5()(64bit)
    libKF5CoreAddons.so.5()(64bit)
    libKF5I18n.so.5()(64bit)
    libKF5KIOGui.so.5()(64bit)
    libKF5ModemManagerQt.so.6()(64bit)
    libKF5Notifications.so.5()(64bit)
    libKF5Package.so.5()(64bit)
    libKF5Plasma.so.5()(64bit)
    libKF5PlasmaQuick.so.5()(64bit)
    libKF5Service.so.5()(64bit)
    libKF5WaylandClient.so.5()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5DBus.so.5()(64bit)
    libQt5DBus.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Qml.so.5()(64bit)
    libQt5Qml.so.5(Qt_5)(64bit)
    libQt5Quick.so.5()(64bit)
    libQt5Quick.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    plasma-milou
    plasma-nano
    plasma-nm
    plasma-pa
    plasma-workspace
    qqc2-breeze-style
    qt5-qtgraphicaleffects
    qt5-qtquickcontrols
    qt5-qtquickcontrols2
    qt5-qtwayland
    rtld(GNU_HASH)



Provides
--------
plasma-phone-components:
    libmobilehomescreencomponentsplugin.so()(64bit)
    libppc-mmqmlplugin.so()(64bit)
    metainfo()
    metainfo(org.kde.phone.activities.appdata.xml)
    metainfo(org.kde.phone.krunner.appdata.xml)
    metainfo(org.kde.plasma.phone.appdata.xml)
    metainfo(org.kde.plasma.phoneshell.appdata.xml)
    plasma-phone-components
    plasma-phone-components(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name plasma-phone-components --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, R, Ocaml, Python, fonts, Haskell, Perl, PHP, SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH